[V8i VBA] Open Next .dgn file

RE: [V8i VBA] Open Next .dgn file

Jon Summers — Sat, 08 Jan 2022 11:15:51 GMT

[quote userid="1106331" url="~/products/programming/microstation_programming/f/microstation-programming---forum/102062/v8i-vba-open-next-dgn-file/690433"]I am browsing the Microsoft Scripting Runtime in Microstation VBA Editor, I cannot find it[/quote]

Once found, it appears at the top of the list.

Several of our example VBA projects use Microsoft Scripting Runtime. For example, Export Line Data to CSV.

RE: [V8i VBA] Open Next .dgn file

Kefan Zhou — Thu, 06 Jan 2022 21:38:44 GMT

Ugh,,,,, thank you!! Mine is on the tenth.

RE: [V8i VBA] Open Next .dgn file

JM — Thu, 06 Jan 2022 21:35:22 GMT

the available references are not sorted 100% alphabetically (at least for me they are not)

try looking near the top of list, mine is in the top 10 if not already selected

if you can't find it in the list I don't know, I think it should be there though

RE: [V8i VBA] Open Next .dgn file

Kefan Zhou — Thu, 06 Jan 2022 21:29:40 GMT

Hi JM,

As I am browsing the Microsoft Scripting Runtime in Microstation VBA Editor, I cannot find it.

However, I can find it in the vba editor in excel.

I try to manually load the scrrun.dll with the Browse, but after loading it, nothing happens in the available references.

Any suggestions?

Regards

RE: [V8i VBA] Open Next .dgn file

JM — Thu, 06 Jan 2022 19:15:20 GMT

if you read the comments at beginning of code you will see

'if Compile error = "User-defined type not defined"
'requires "MicroSoft Scripting Runtime" reference (Tools> References)

you need to add the reference in VBA IDE, it won't work without it

RE: [V8i VBA] Open Next .dgn file

Kefan Zhou — Thu, 06 Jan 2022 19:09:54 GMT

Hi Jan,

I tried to run this code in Microstation mvba, following shows:

Any suggestion how to resolve this? I still don't quite get what "Scripting. " stands for.

Regards,

RE: [V8i VBA] Open Next .dgn file

Jon Summers — Sun, 06 May 2018 07:11:52 GMT

[quote userid="869597" url="~/products/programming/microstation_programming/f/microstation-programming---forum/102062/v8i-vba-open-next-dgn-file/459319"]I want to find the input tool to list the .dgn files in the directory,[/quote]

Take a look at this VBA project Next File for MicroStation.

RE: [V8i VBA] Open Next .dgn file

Doan Nguyen Thuc — Sun, 06 May 2018 06:05:39 GMT

I want to find the input tool to list the .dgn files in the directory, by scanning the selected folders, maybe at different paths, then if i press forward then it will open the next file Otherwise, it will back up, or I will choose a random file and it will open to the file. DGN, hope you help me. Thank you very much, good day

RE: [V8i VBA] Open Next .dgn file

Doan Nguyen Thuc — Sun, 06 May 2018 06:04:38 GMT

RE: [V8i VBA] Open Next .dgn file

JJ Wutt — Thu, 23 Oct 2014 14:13:28 GMT

Jon, Excellent point. Thanks!

RE: [V8i VBA] Open Next .dgn file

JJ Wutt — Thu, 23 Oct 2014 14:12:32 GMT

Jan, Thanks for the book suggestions and comments! I will have to check those out.

RE: [V8i VBA] Open Next .dgn file

Jon Summers — Thu, 23 Oct 2014 06:33:59 GMT

[quote user=""JJ"]If Right(oFile.Name, 3) = "dgn" Then[/quote]

That tells you if a three-letter file extension matches 'dgn' exactly. What if the extension is 'DGN' (i.e. upper-case DGN not lower-case dgn)? What if the project uses DGN files having a different extension?

Read this article about how to Check a Design File with VBA. It shows a way to check any file to find if MicroStation can open it.

RE: [V8i VBA] Open Next .dgn file

Jan Šlegr — Thu, 23 Oct 2014 04:25:12 GMT

Hi,

[quote user="JJ Wutt"]It works, but I'm a novice at programming and I wonder if the code could be streamlined (better organized?)[/quote]

It's an eternal question if a code is good enough or can be implemented in some better way ... but at the same time what does it mean "better way" is also important and tricky question ;-) To ask these questions are in my opinion one of mandatory conditions to become better programmer.

If you are serious about your development skills, I strongly recommend to read Clean Code: A Handbook of Agile Software Craftsmanship (don't mix up with The Clean Coder: A Code of Conduct for Professional Programmers from the same author). If you are beginner, the first 7 or 8 chapters are the most valuable for you and you will find plenty of ideas and examples how to refactor the code to be better (and also some ideas what "better" means). Don't care the examples are in Java, overall concepts and ideas are general.

Also webs like StackExchange (especially Programmers and Stack Overflow) can provide you plenty of advices and ideas what rules to follow to create better code (e.g. check this discussion).

Reading your code (and not thinking too much about it as VBA is not my favorite languge ;-), I recommend to follow a rule of a single responsibility, which comes from object oriented programming world, but can be used also in VBA: One function has to be responsible for one thing. Contrary to the rule, your code does many things (creates array of file names, iterate through it, opens file etc.) If you will break the code to more subs, you will also be closer to a rule every function should be short (even just a few lines).

With regards,

Jan