Issues with Import-PWDocumentsFromArchive

Thanks for reporting the issue about the wrong applications being created.  We have confirmed the issue and it should be fixed next release.  As for not supporting relative paths we're not going to be doing anything about that any time soon, assuming it's really the case.  Please use Set-Location to confirm the current directory is really what you think it is.   Yes, the cmdlet checks whether the input SQLite file actually exists and this check seems to work in the vast majority of cases.  It issues a warning and quits when the input file does not exist. I'm not sure we'll handle the multiple extensions either

Mark Weisman | Bentley Systems 

Thanks for reporting the issue about the wrong applications being created.  We have confirmed the issue and it should be fixed next release.  As for not supporting relative paths we're not going to be doing anything about that any time soon, assuming it's really the case.  Please use Set-Location to confirm the current directory is really what you think it is.   Yes, the cmdlet checks whether the input SQLite file actually exists and this check seems to work in the vast majority of cases.  It issues a warning and quits when the input file does not exist. I'm not sure we'll handle the multiple extensions either

Mark Weisman | Bentley Systems 

Thanks on the applications, it'll be a big help.

I suspect what's happening on the the path is that I use tab completion to fill in the name of sqlite file from the local directory. In powershell when you do this it makes the path to the file .\filename, adding the .\ makes it a relative path and that fails. I have not tried using a filename without the .\

Out of curiosity, is there a code or security or just time reason for not supporting relative paths? I assumed (famous last words) the .net GetFullPath made it easy to convert a relative path to a full path and then check that.

Ok, the fact that tab justification yields relative paths makes this worth investigating some time in the future.    It isn't obvious why the cmdlet code is not supporting relative paths.  It is not explicitly rejecting them.  As for support of relative paths being a security issue -- food for thought (and the prioritization of the issue).  Perhaps PowerShell should not have tab justification

Thanks,

Mark Weisman | Bentley Systems

I would die with out tab completion! Powershell doesn’t support the old windows behavior for executing things in the current directory automatically when no path is provided which probably fixes a bunch of exploit. Tab completion adding the .\ automatically is probably a partial fix as it shows you exactly which file will be used.

Not a big deal pwps_dab doesn’t support it yet.

thanks again

I've wrapped a number of the PWPS_DAB cmdlets with my own functions named something like Import-PWDocumentsFromArchive2 to add some pre/post process functionality and extend the original cmdlet. Might be an option to do that and add your own relative path tab completion handling in the interim although admitedly that particular cmdlet has a few more switches than normal to passthrough correctly.

Code is untested but this is the idea.

function Import-PWDocumentsFromArchive2 {
    <#
    .SYNOPSIS
        Imports files, metadata and audit trail info from a SQLite archive container generated by Export-PWDocumentsToArchive.

    .DESCRIPTION
        Import folders, files, metadata, and audit trail from a SQLite database.

    .PARAMETER InputFile
        Path and SQLLite file to import from. Will not look for it in local folder by default.

    .PARAMETER TargetProjectWiseFolder
        Target parent folder. Builds relative folders beneath.
        
    .PARAMETER DefaultStorage
        Storage for new folders. If not included, the parent folder's storage area is used.
        
    .PARAMETER ReplaceIfExists
        If file exists in ProjectWise, replace it. Will version if not set.
        
    .PARAMETER LocalFolder
        Local folder for extracting files.
        
    .PARAMETER EnvironmentsOnly
        Just import environments.
        
    .PARAMETER SkipDocumentAttributeUpdate
        When included, document attributes will NOT be updated.
                
    .PARAMETER SkipSecondaryAttributeUpdate
        When included, a secondary attempt to update individual document attributes will not be performed.
        
        This secondary attempt to update document attributes ONLY occurs when the initial attempt to update ALL document attributes fails.

    .PARAMETER RetainFileNames
        When included, if versions of being created, the filename of the source file will NOT overwrite the existing file name.

    .PARAMETER ExcludeEnvironments
        Don't import environments.
        
        If the environments are already in your datasource, use this switch.

    .PARAMETER UpdateExistingEnvironments

    .NOTES
        Name: Import-PWDocumentsFromArchive2.ps1
        DateCreated: 2023-10-25

    .EXAMPLE
        ----------  EXAMPLE 1  ----------
    
        Will import documents from an archive container.
        Import-PWDocumentsFromArchive -InputFile 'c:\export\export.sqlite' -TargetFolder "Imports\From Disk" -DefaultStorage Storage01 -ReplaceIfExists
    
        ----------  EXAMPLE 2  ----------
    
        Will import documents from an archive container. Uses a local folder and the document attributes will not be updated.
        Import-PWDocumentsFromArchive -InputFile 'c:\export\export.sqlite' -TargetFolder "Imports\From Disk" -LocalFolder 'd:\temp' -SkipDocumentAttributeUpdate -ReplaceIfExists
    #>

    [CmdletBinding()]
    Param (
        [Parameter (Mandatory, Position = 0)]
        [ValidateNotNullOrEmpty()]
        [String] $InputFile,

        [Parameter (Position = 1)]
        [ValidateNotNullOrEmpty()]
        [String] $TargetProjectWiseFolder,

        [Parameter (Position = 2)]
        [ValidateNotNullOrEmpty()]
        [String] $DefaultStorage,

        [Parameter (Position = 3)]
        [Switch] $ReplaceIfExists,
        
        [Parameter (Position = 4)]
        [ValidateNotNullOrEmpty()]
        [String] $LocalFolder,

        [Parameter (Position = 5)]
        [Switch] $EnvironmentsOnly,
        
        [Parameter ()]
        [Switch] $ExcludeEnvironments,

        [Parameter ()]
        [Switch] $RetainFileNames,

        [Parameter ()]
        [Switch] $SkipDocumentAttributeUpdate,

        [Parameter ()]
        [Switch] $SkipSecondaryAttributeUpdate,

        [Parameter ()]
        [Switch] $UpdateExistingEnvironments
    )

    Begin {
        Write-Verbose $MyInvocation.MyCommand.Name

        if (!(Get-PWCurrentDatasource -Verbose:$false)) {
            Write-Error 'Not logged into a ProjectWise datasource.'
            break
        }
    }

    Process {
        $Splat = @{
            InputFile                   = if ($InputFile.StartsWith('.\')) { $InputFile.Replace('.\', "$((Get-Location).Path)\") } else { $InputFile }
            #TargetProjectWiseFolder
            #DefaultStorage
            ReplaceIfExists              = $ReplaceIfExists
            #LocalFolder
            EnvironmentsOnly             = $EnvironmentsOnly
            ExcludeEnvironments          = $ExcludeEnvironments
            RetainFileNames              = $RetainFileNames
            SkipDocumentAttributeUpdate  = $SkipDocumentAttributeUpdate
            SkipSecondaryAttributeUpdate = $SkipSecondaryAttributeUpdate
            UpdateExistingEnvironments   = $UpdateExistingEnvironments
        }
        if ($TargetProjectWiseFolder) { $Splat.Add('TargetProjectWiseFolder', $TargetProjectWiseFolder) }
        if ($DefaultStorage)          { $Splat.Add('DefaultStorage'         , $DefaultStorage) }
        if ($LocalFolder)             { $Splat.Add('LocalFolder'            , $LocalFolder) }

        return Import-PWDocumentsFromArchive @Splat
    }                      

    End {}
}